Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1002 #1005

Merged
merged 5 commits into from
Apr 24, 2023
Merged

#1002 #1005

merged 5 commits into from
Apr 24, 2023

Conversation

joocer
Copy link
Contributor

@joocer joocer commented Apr 24, 2023

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to help make sure it goes smoothly:

  • Raise a bug/feature request or start a discussion, ideally before writing your code! That way we can discuss the change and the approach.
  • Ensure the tests pass
  • Ensure code coverage does not decrease (if any source code was changed)
  • Appropriate docs and tests were updated (if necessary)

Fixes #<issue_number_goes_here>

@ghost
Copy link

ghost commented Apr 24, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #1005 (50f07a0) into main (e56bc57) will increase coverage by 0.08%.
The diff coverage is 97.29%.

@@            Coverage Diff             @@
##             main    #1005      +/-   ##
==========================================
+ Coverage   95.70%   95.78%   +0.08%     
==========================================
  Files         191      193       +2     
  Lines        7917     7949      +32     
==========================================
+ Hits         7577     7614      +37     
+ Misses        340      335       -5     
Impacted Files Coverage Δ
opteryx/__main__.py 88.52% <ø> (+11.10%) ⬆️
opteryx/utils/__init__.py 68.57% <ø> (ø)
opteryx/connection.py 99.00% <92.30%> (-1.00%) ⬇️
opteryx/command.py 100.00% <100.00%> (ø)
opteryx/version.py 100.00% <100.00%> (ø)
tests/misc/test_cli.py 100.00% <100.00%> (ø)
tests/misc/test_connection_arrow.py 100.00% <100.00%> (ø)
tests/storage/test_sql_duckdb.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Apr 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joocer joocer merged commit acf1fd6 into main Apr 24, 2023
26 of 27 checks passed
@joocer joocer deleted the #1002 branch April 24, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant