Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1008 #1009

Merged
merged 3 commits into from
Apr 25, 2023
Merged

#1008 #1009

merged 3 commits into from
Apr 25, 2023

Conversation

joocer
Copy link
Contributor

@joocer joocer commented Apr 25, 2023

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to help make sure it goes smoothly:

  • Raise a bug/feature request or start a discussion, ideally before writing your code! That way we can discuss the change and the approach.
  • Ensure the tests pass
  • Ensure code coverage does not decrease (if any source code was changed)
  • Appropriate docs and tests were updated (if necessary)

Fixes #<issue_number_goes_here>

@sonarcloud
Copy link

sonarcloud bot commented Apr 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #1009 (217b939) into main (acf1fd6) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 217b939 differs from pull request most recent head 187af55. Consider uploading reports for the commit 187af55 to get more accurate results

@@            Coverage Diff             @@
##             main    #1009      +/-   ##
==========================================
- Coverage   95.79%   95.78%   -0.02%     
==========================================
  Files         193      193              
  Lines        7949     7950       +1     
==========================================
  Hits         7615     7615              
- Misses        334      335       +1     
Impacted Files Coverage Δ
...ests/sql_battery/test_shapes_and_errors_battery.py 93.93% <ø> (ø)
opteryx/models/columns.py 99.25% <100.00%> (+<0.01%) ⬆️
opteryx/operators/file_reader_node.py 83.07% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joocer joocer merged commit d96b73e into main Apr 25, 2023
@joocer joocer deleted the #1008 branch April 25, 2023 23:14
@ghost
Copy link

ghost commented Apr 25, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant