Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1015 #1016

Merged
merged 2 commits into from
Apr 28, 2023
Merged

#1015 #1016

merged 2 commits into from
Apr 28, 2023

Conversation

joocer
Copy link
Contributor

@joocer joocer commented Apr 28, 2023

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to help make sure it goes smoothly:

  • Raise a bug/feature request or start a discussion, ideally before writing your code! That way we can discuss the change and the approach.
  • Ensure the tests pass
  • Ensure code coverage does not decrease (if any source code was changed)
  • Appropriate docs and tests were updated (if necessary)

Fixes #<issue_number_goes_here>

@ghost
Copy link

ghost commented Apr 28, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #1016 (0ef67da) into main (f357ba1) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1016      +/-   ##
==========================================
+ Coverage   95.83%   95.94%   +0.10%     
==========================================
  Files         195      195              
  Lines        8024     8055      +31     
==========================================
+ Hits         7690     7728      +38     
+ Misses        334      327       -7     
Impacted Files Coverage Δ
...nts/tree_rewriter/rules/rule_predicate_pushdown.py 95.83% <ø> (ø)
opteryx/operators/blob_reader_node.py 97.56% <100.00%> (+0.03%) ⬆️
opteryx/operators/file_reader_node.py 92.53% <100.00%> (+9.46%) ⬆️
opteryx/operators/sql_reader_node.py 93.18% <100.00%> (+0.49%) ⬆️
opteryx/third_party/query_builder/builder.py 96.03% <100.00%> (ø)
.../query_planning/test_predicate_pushdown_parquet.py 100.00% <100.00%> (ø)
...query_planning/test_predicate_pushdown_postgres.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joocer joocer merged commit 61b554d into main Apr 28, 2023
@joocer joocer deleted the #1015 branch April 28, 2023 20:47
@joocer joocer restored the #1015 branch May 1, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant