Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1354 #1369

Merged
merged 2 commits into from
Jan 10, 2024
Merged

#1354 #1369

merged 2 commits into from
Jan 10, 2024

Conversation

joocer
Copy link
Contributor

@joocer joocer commented Jan 10, 2024

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to help make sure it goes smoothly:

  • Raise a bug/feature request or start a discussion, ideally before writing your code! That way we can discuss the change and the approach.
  • Ensure the tests pass
  • Ensure code coverage does not decrease (if any source code was changed)
  • Appropriate docs and tests were updated (if necessary)

Fixes #1354

Copy link

sonarcloud bot commented Jan 10, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ghost
Copy link

ghost commented Jan 10, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@joocer joocer merged commit 22462ba into main Jan 10, 2024
3 of 4 checks passed
@joocer joocer deleted the #1354 branch January 10, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ constant folding
2 participants