Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1402 #1403

Merged
merged 2 commits into from
Jan 26, 2024
Merged

#1402 #1403

merged 2 commits into from
Jan 26, 2024

Conversation

joocer
Copy link
Contributor

@joocer joocer commented Jan 26, 2024

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to help make sure it goes smoothly:

  • Raise a bug/feature request or start a discussion, ideally before writing your code! That way we can discuss the change and the approach.
  • Ensure the tests pass
  • Ensure code coverage does not decrease (if any source code was changed)
  • Appropriate docs and tests were updated (if necessary)

Fixes #1402

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (3e06b5e) 94.48% compared to head (a40fb04) 94.47%.
Report is 21 commits behind head on main.

❗ Current head a40fb04 differs from pull request most recent head 72d8e55. Consider uploading reports for the commit 72d8e55 to get more accurate results

Files Patch % Lines
opteryx/functions/__init__.py 84.61% 2 Missing ⚠️
opteryx/shared/rolling_log.py 80.00% 2 Missing ⚠️
opteryx/managers/expression/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1403      +/-   ##
==========================================
- Coverage   94.48%   94.47%   -0.01%     
==========================================
  Files         211      212       +1     
  Lines        9352     9364      +12     
==========================================
+ Hits         8836     8847      +11     
- Misses        516      517       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 26, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@joocer joocer merged commit c7e06d7 into main Jan 26, 2024
2 of 3 checks passed
@joocer joocer deleted the #1402 branch January 26, 2024 22:03
@ghost
Copy link

ghost commented Jan 26, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🪲 tests with testdata.flat.different execute differently on different environments
2 participants