Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#165 #166

Merged
merged 8 commits into from
Jun 4, 2022
Merged

Feature/#165 #166

merged 8 commits into from
Jun 4, 2022

Conversation

joocer
Copy link
Contributor

@joocer joocer commented Jun 4, 2022

No description provided.

@ghost
Copy link

ghost commented Jun 4, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@sonarcloud
Copy link

sonarcloud bot commented Jun 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jun 4, 2022

Codecov Report

Merging #166 (ab85735) into main (e62a086) will increase coverage by 0.54%.
The diff coverage is 98.49%.

@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   90.92%   91.47%   +0.54%     
==========================================
  Files          71       75       +4     
  Lines        2678     2767      +89     
==========================================
+ Hits         2435     2531      +96     
+ Misses        243      236       -7     
Impacted Files Coverage Δ
opteryx/storage/adapters/blob/disk_store.py 100.00% <ø> (ø)
opteryx/storage/adapters/blob/gcs_store.py 100.00% <ø> (ø)
tests/storage/test_minio_storage.py 96.77% <96.77%> (ø)
opteryx/engine/planner/execution_tree.py 97.36% <97.36%> (ø)
opteryx/engine/planner/operations/__init__.py 100.00% <100.00%> (ø)
opteryx/engine/planner/planner.py 95.22% <100.00%> (+1.02%) ⬆️
opteryx/storage/adapters/__init__.py 100.00% <100.00%> (ø)
opteryx/storage/adapters/blob/__init__.py 100.00% <100.00%> (ø)
opteryx/storage/adapters/blob/minio_store.py 100.00% <100.00%> (ø)
opteryx/storage/base_storage_adapter.py 88.88% <100.00%> (+3.70%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e62a086...ab85735. Read the comment docs.

@joocer joocer merged commit f875e99 into main Jun 4, 2022
@joocer joocer deleted the FEATURE/#165 branch June 4, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant