Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#234 #236

Merged
merged 3 commits into from
Jun 26, 2022
Merged

Feature/#234 #236

merged 3 commits into from
Jun 26, 2022

Conversation

joocer
Copy link
Contributor

@joocer joocer commented Jun 26, 2022

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Jun 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #236 (586ad20) into main (cbcd0ee) will decrease coverage by 0.02%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   92.46%   92.44%   -0.03%     
==========================================
  Files          93       93              
  Lines        3572     3588      +16     
==========================================
+ Hits         3303     3317      +14     
- Misses        269      271       +2     
Impacted Files Coverage Δ
tests/sql_battery/test_battery_shape.py 100.00% <ø> (ø)
tests/sql_battery/test_expect_to_fail.py 100.00% <ø> (ø)
opteryx/engine/functions/__init__.py 91.89% <87.50%> (ø)
opteryx/engine/functions/other_functions.py 92.85% <87.50%> (-7.15%) ⬇️
opteryx/config.py 87.50% <100.00%> (ø)
opteryx/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbcd0ee...586ad20. Read the comment docs.

@ghost
Copy link

ghost commented Jun 26, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@joocer joocer merged commit 633aa7b into main Jun 26, 2022
@joocer joocer deleted the FEATURE/#234 branch June 26, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant