getCSSProperty.js #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pat-hanbury
approved these changes
Jan 28, 2021
| //let selector = getElementByXpath(mablInputs.variables.user.selector_xpath); | ||
|
|
||
| // using a css selector | ||
| let selector = document.querySelector(mablInputs.variables.user.selector_css); |
There was a problem hiding this comment.
The result of querySelector isn't a selector, but rather an element. Would it make sense to change this variable name to element and the one below this to style?
[nit] - selector_css could be be selectorCss to match the camel casing used below.
| // using a css selector | ||
| let selector = document.querySelector(mablInputs.variables.user.selector_css); | ||
|
|
||
| let element = getComputedStyle(selector); |
There was a problem hiding this comment.
so I'm curious, we don't need window.getComputedStyle here right? it seems to work fine in dev tools when I'm testing it without window. I don't much about how the scoping works for our javascript snippets. Would be an easy thing to test though.
| callback(element.getPropertyValue(mablInputs.variables.user.css_property)); | ||
| } | ||
|
|
||
| function getElementByXpath(path) { |
There was a problem hiding this comment.
good idea having this here, it's handy :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.