Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

currentNode undefined #30

Closed
kapet opened this issue Sep 28, 2021 · 1 comment · Fixed by #31 or #33
Closed

currentNode undefined #30

kapet opened this issue Sep 28, 2021 · 1 comment · Fixed by #31 or #33

Comments

@kapet
Copy link
Contributor

kapet commented Sep 28, 2021

in NukiBridgeControl.prototype.handleBridgeEvent:
currentNode is not defined

I think s/currentNode/node/ is the necessary fix
mabunixda added a commit that referenced this issue Sep 28, 2021
@mabunixda
fix #30
4a0e822
@mabunixda mabunixda mentioned this issue Sep 28, 2021
Merged
mabunixda added a commit that referenced this issue Sep 28, 2021
@mabunixda
fix #30 (#31)
e1d27a6 
* fix #30
@kapet
Copy link
Contributor Author

kapet commented Oct 12, 2021

Sorry, the fix didn't work. The problem is that the code in NukiBridgeControl.prototype.handleBridgeEvent uses BOTH 'node' and 'currentNode'.

I'll try to submit a pull request for a fix.

@kapet kapet mentioned this issue Oct 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #30 mabunixda/node-red-contrib-nuki
s/currentNode/node/ kapet/node-red-contrib-nuki
1 participant
@kapet