Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings are generated for segues with an empty identifier where they shouldn't be #525

Closed
mbernson opened this issue May 31, 2019 · 1 comment · Fixed by #555
Closed

Warnings are generated for segues with an empty identifier where they shouldn't be #525

mbernson opened this issue May 31, 2019 · 1 comment · Fixed by #555

Comments

@mbernson
Copy link
Collaborator

Steps to reproduce:

  1. Create a 'show' segue or similar between two viewcontrollers in a storyboard
  2. Give it an identifier
  3. Clear the identifier field again

Expected result:

  1. I don't get any warnings

Result:

  1. Because the segue identifier in the storyboard XML is now an empty string instead of a null, I get the warning [R.swift] Skipping 1 segue for 'FooController' because no swift identifier can be generated for segue: ''
@mbernson
Copy link
Collaborator Author

@mac-cain13 This one seems easy, I will pick it up soon-ish and submit a PR. :)

mbernson added a commit to mbernson/R.swift that referenced this issue Sep 12, 2019
@mbernson
SegueGenerator: Skip segues that have an empty identifier
fc4de95 
Closes mac-cain13#525
@mbernson mbernson mentioned this issue Sep 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SegueGenerator: Skip segues that have an empty identifier mbernson/R.swift
1 participant
@mbernson