Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localizable strings comments #283

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Localizable strings comments #283

wants to merge 10 commits into from

Commits on Jul 2, 2016

  1. Use a regex to parse .strings files

    @nolanw
    nolanw committed Jul 2, 2016
    Configuration menu
    Copy the full SHA
    666bb86 View commit details
    Browse the repository at this point in the history

  2. Return array of structs from LocalizableStrings 

    The returned struct includes any comment associated with the strings file entry. Returning an array allows for future features such as detecting duplicates within a single file.
    @nolanw
    nolanw committed Jul 2, 2016
    Configuration menu
    Copy the full SHA
    21866d8 View commit details
    Browse the repository at this point in the history

  3. Include strings file entry comments in R.generated.swift property com… 

    …ments
    @nolanw
    nolanw committed Jul 2, 2016
    Configuration menu
    Copy the full SHA
    7cf54f9 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2016

  1. Generate comment parameter for StringResource and update R.swift.Libr… 

    …ary to include comment parameter
    @nolanw
    nolanw committed Aug 9, 2016
    Configuration menu
    Copy the full SHA
    b6e3a77 View commit details
    Browse the repository at this point in the history

  2. Create Comments.strings in ResourceApp

    @nolanw
    nolanw committed Aug 9, 2016
    Configuration menu
    Copy the full SHA
    71542ae View commit details
    Browse the repository at this point in the history

  3. Include comments in generated StringsResources and test them

    @nolanw
    nolanw committed Aug 9, 2016
    Configuration menu
    Copy the full SHA
    d8f2408 View commit details
    Browse the repository at this point in the history

  4. Parse .strings files using NSScanner instead of regex

    @nolanw
    nolanw committed Aug 9, 2016
    Configuration menu
    Copy the full SHA
    542fb96 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2016

  1. Merge branch 'master' into nolanw-localizable-strings-comments

    @tomlokhorst
    tomlokhorst committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    21ea962 View commit details
    Browse the repository at this point in the history

  2. Fixed some localized string comment tests

    @tomlokhorst
    tomlokhorst committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    4860037 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2017

  1. Merge branch 'master' into localizable-strings-comments 

    # Conflicts:
#	ResourceApp/ResourceApp.xcodeproj/project.pbxproj
    @mac-cain13
    mac-cain13 committed Apr 5, 2017
    Configuration menu
    Copy the full SHA
    d6ded47 View commit details
    Browse the repository at this point in the history