Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StoryboardViewControllerIdentifier.callAsFunction(creator:) should return non-optional value #890

Merged

Conversation

hujunfeng
Copy link
Contributor

This method calls UIStoryboard.instantiateViewController(identifier:creator:) internally, which returns a non-optional view controller. Therefore, it is unnecessary to return optional value in the StoryboardViewControllerIdentifier method.

See also: https://developer.apple.com/documentation/uikit/uistoryboard/3213989-instantiateviewcontroller

@tomlokhorst
Copy link
Collaborator

Thanks!

@tomlokhorst tomlokhorst merged commit 27c061c into mac-cain13:main Apr 2, 2024
2 checks passed
@hujunfeng hujunfeng deleted the remove-optional branch April 26, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants