Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace shouldRecognizeDrag delegate methods with variables #69

Merged
merged 1 commit into from
May 25, 2020

Conversation

mac-gallagher
Copy link
Owner

@mac-gallagher mac-gallagher commented May 25, 2020

  • Make SwipeCardStack.animationOptions open instead of public
  • Make SwipeCardStack.numberOfVisibleCards internal. The reason for doing this is because right now there is no visible effect from changing it to anything other than the default 2. Will make this public again if there is ever a change to the visual card stack layout
  • Simplify solution to Allow card movement to swipe only defined directions #64 by replacing all delegate methods with shouldRecognizeHorizontalDrag/shouldRecognizeVerticalDrag on SwipeCardStack

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2020

Codecov Report

Merging #69 into master will decrease coverage by 0.19%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   82.26%   82.07%   -0.20%     
==========================================
  Files          13       13              
  Lines         654      647       -7     
==========================================
- Hits          538      531       -7     
  Misses        116      116              
Impacted Files Coverage Δ
...urces/Shuffle/SwipeCard/CardAnimationOptions.swift 100.00% <ø> (ø)
...fle/SwipeCardStack/CardStackAnimationOptions.swift 100.00% <ø> (ø)
...ces/Shuffle/SwipeCardStack/CardStackAnimator.swift 0.00% <0.00%> (ø)
...uffle/SwipeCardStack/CardStackLayoutProvider.swift 100.00% <ø> (ø)
...Shuffle/SwipeCardStack/CardStackStateManager.swift 100.00% <ø> (ø)
...le/SwipeCardStack/CardStackTransformProvider.swift 0.00% <ø> (ø)
Sources/Shuffle/SwipeDirection.swift 100.00% <ø> (ø)
Sources/Shuffle/SwipeCard/CardAnimator.swift 100.00% <100.00%> (ø)
Sources/Shuffle/SwipeCard/CardLayoutProvider.swift 100.00% <100.00%> (ø)
...rces/Shuffle/SwipeCard/CardTransformProvider.swift 100.00% <100.00%> (ø)
... and 15 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants