Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add insertCard and appendCards methods #89

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Conversation

mac-gallagher
Copy link
Owner

  • Add the following methods the SwipeCardStack:
    • func numberOfRemainingCards() -> Int
    • func insertCard(atIndex index: Int, position: Int)
    • func appendCards(atIndices indices: [Int])
  • Rename position(forCardAtIndex index: Int) method to positionforCard(at index: Int)

This addresses #13

@mac-gallagher mac-gallagher marked this pull request as draft July 7, 2020 04:29
@mac-gallagher mac-gallagher force-pushed the insertCard branch 2 times, most recently from 03e6294 to acb2529 Compare July 7, 2020 04:35
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2020

Codecov Report

Merging #89 into master will increase coverage by 0.6%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##           master     #89     +/-   ##
========================================
+ Coverage    82.5%   83.1%   +0.6%     
========================================
  Files          13      13             
  Lines         663     687     +24     
========================================
+ Hits          547     571     +24     
  Misses        116     116             
Impacted Files Coverage Δ
...Shuffle/SwipeCardStack/CardStackStateManager.swift 100.0% <100.0%> (ø)
...ources/Shuffle/SwipeCardStack/SwipeCardStack.swift 99.4% <100.0%> (+<0.1%) ⬆️

@mac-gallagher mac-gallagher force-pushed the insertCard branch 4 times, most recently from d8c67d7 to 14583bf Compare July 7, 2020 10:28
@mac-gallagher mac-gallagher marked this pull request as ready for review July 7, 2020 10:30
@mac-gallagher mac-gallagher self-assigned this Jul 7, 2020
@mac-gallagher mac-gallagher added the enhancement New feature or request label Jul 7, 2020
@mac-gallagher mac-gallagher merged commit 94bbd30 into master Jul 7, 2020
@mac-gallagher mac-gallagher deleted the insertCard branch July 7, 2020 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants