Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added --no-watch option #24

Merged
merged 4 commits into from
Jan 8, 2021
Merged

added --no-watch option #24

merged 4 commits into from
Jan 8, 2021

Conversation

LokiMidgard
Copy link
Contributor

I have added a no-watch option, for build systems.

this way it can be ensured that when the project is packed on a build server it will update the type definitions to the latest version.

since it is the only optional option, i just look for --no-watch on index forth of the process arguments. If in future there could be more it may be worth to add an command line argument parsing library.

@macabeus
Copy link
Owner

macabeus commented Jan 8, 2021

Nice feature! Thanks!
I just improved a little the code quality (splitting into smaller files and removing hosting), fixed your commit author (check this comment), added a warning message, and updated the doc.

@macabeus macabeus merged commit 572fdf4 into macabeus:master Jan 8, 2021
@macabeus
Copy link
Owner

macabeus commented Jan 8, 2021

@LokiMidgard I just launched the new version with your both changes (https://github.com/macabeus/fluent-typescript/releases/tag/0.0.6).
Let me know if everything is working fine.

@LokiMidgard
Copy link
Contributor Author

@macabeus I updated my project and it seems to work fine 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants