gba.js save states

[city41]

Hi! Thanks for making this project and the Medium posts you wrote about it. It's been very helpful for me, as I'm making a similar tool for Super Mario Advance 4.

I just wanted to let you know I just got save states working in gba.js, so now in my Mario editor, the user can jump into their level really fast. I juuuuuust got them working, so the code is pretty bad. But if you want to add save state support to klo-gba, should be able to do it.

My project is here: https://github.com/city41/smaghetti

[macabeus]

Very thank you! It was one of the missing features that I really wanted to add.
And very nice to hear that my project and posts was useful for your project =]

Before putting this project on hold, I was looking to extract react-gbajs into a new package. Maybe it would be useful to do now?

[macabeus]

It's weird... I did clone and setup up the project again, and I got to reproduce this bug. I really didn't notice when it started to happen.
I'm trying to fix it now.

[macabeus]

@city41 I'm still investigating more about the bug, but just to unblock you: apply the following patch:

diff --git a/scissors/src/huffman.js b/scissors/src/huffman.js
index da87d49..f94f03b 100644
--- a/scissors/src/huffman.js
+++ b/scissors/src/huffman.js
@@ -19,7 +19,7 @@ class HuffmanDecodeError extends Error {
   }
 }
 
-huffmanModule.onRuntimeInitialized = () => {}
+// huffmanModule.onRuntimeInitialized = () => {}
 
 const huffmanDecode = (buffer) => {
   FS.writeFile('file', buffer)
diff --git a/scissors/src/lzss.js b/scissors/src/lzss.js
index a126bbb..8337b27 100644
--- a/scissors/src/lzss.js
+++ b/scissors/src/lzss.js
@@ -19,7 +19,7 @@ class LzssDecodeError extends Error {
   }
 }
 
-lzssModule.onRuntimeInitialized = () => {}
+// lzssModule.onRuntimeInitialized = () => {}
 
 const lzssDecode = (buffer) => {
   FS.writeFile('filelzss', buffer)

Probably it'll fix the bug.

[macabeus]

I forgot to set a specific version on the docker image. Probably it's the root of the bug 🤦

klo-gba.js/shellscript/compile-webassembly.sh

Line 9 in b1f5cd9

trzeci/emscripten \

[macabeus]

Done. Fixed: #95

[city41]

awesome! thanks for the quick fix!