feat: use get with screenshot

macacajs · Jul 16, 2020 · 434720f · 434720f
1 parent bb64a0b
commit 434720f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/test/screenshot.test.js b/test/screenshot.test.js
@@ -34,7 +34,7 @@ describe('test/screenshot.test.js', function() {
   describe('saveScreenshot', async () => {
     it('should work', async () => {
       await driver.saveScreenshot();
-      assert.equal(server.ctx.method, 'POST');
+      assert.equal(server.ctx.method, 'GET');
       assert.equal(server.ctx.url, '/wd/hub/session/screenshot');
       assert.deepEqual(server.ctx.request.body, {});
       assert.deepEqual(server.ctx.response.body, {
@@ -50,10 +50,8 @@ describe('test/screenshot.test.js', function() {
    */
   describe('takeScreenshot', async () => {
     it('should work', async () => {
-      await driver.takeScreenshot('', {
-        fullPage: true,
-      });
-      assert.equal(server.ctx.method, 'POST');
+      await driver.takeScreenshot();
+      assert.equal(server.ctx.method, 'GET');
       assert.equal(server.ctx.url, '/wd/hub/session/screenshot');
       assert.deepEqual(server.ctx.request.body, {});
       assert.deepEqual(server.ctx.response.body, {

diff --git a/wd/lib/commands.js b/wd/lib/commands.js
@@ -1104,10 +1104,9 @@ commands.takeScreenshot = function() {
   var cb = findCallback(arguments);
   var params = arguments[0];
   this._jsonWireCall({
-    method: 'POST'
-    , relPath: '/screenshot'
+    method: 'GET'
+    , relPath: `/screenshot${url.format({query: params})}`
     , cb: callbackWithData(cb, this)
-    , data: params
   });
 };