Pydantic 2 Update #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update all classic computer models. Classic computer model tests pass.
Classic category model tests pass.
Classic computer group model tests pass.
Classic network segment model tests pass.
brysontyrrell
added
bug
|
This also fixes two bugs I found (one in Pro pagination). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This large pull request is an update to the project to move from Pydantic v1 to v2. When the SDK project first started v2 was only being planned. Now that it has matured it's time for this project to adopt the latest version. This should address some conflicts that have been encountered in environments where v2 was already installed, and it should also provide an execution speed increase.
Most of the changes are switching from deprecated model configs and methods to the new v2 options. All
Optionalfields must have a default in v2 (the SDK models all default toNoneas was the behavior before this update). This is the repetitive bulk of the PR. Most notable is the swap ofExtraandConfigformodel_confg/ConfigDict.All existing tests have been ensured to pass without modification beyond changing out v1 to v2 Pydantic code. Additional tests have been added for the webhook generators to ensure those models produce mock client data as expected.
There is a new integration test file that uses the dummy Jamf Cloud instance provided by Jamf for integration tests. These tests will not be used in GitHub Actions yet. A long term plan for integration testing will be worked out, but locally this allows developers to ensure live read operations work as expected.