Skip to content

Commit

Permalink
Add hideDeferralCount preferences
Browse files Browse the repository at this point in the history
  • Loading branch information
natewalck committed Jul 28, 2021
1 parent 73cec7d commit a2008e6
Show file tree
Hide file tree
Showing 8 changed files with 35 additions and 8 deletions.
1 change: 1 addition & 0 deletions Example Assets/com.github.macadmins.Nudge.json
Expand Up @@ -54,6 +54,7 @@
"fallbackLanguage": "en",
"forceFallbackLanguage": false,
"forceScreenShotIcon": false,
"hideDeferralCount": false,
"iconDarkPath": "/somewhere/logoDark.png",
"iconLightPath": "/somewhere/logoLight.png",
"screenShotDarkPath": "/somewhere/screenShotDark.png",
Expand Down
2 changes: 2 additions & 0 deletions Example Assets/com.github.macadmins.Nudge.mobileconfig
Expand Up @@ -110,6 +110,8 @@
<false/>
<key>forceScreenShotIcon</key>
<false/>
<key>hideDeferralCount</key>
<false/>
<key>iconDarkPath</key>
<string>/somewhere/logoDark.png</string>
<key>iconLightPath</key>
Expand Down
1 change: 1 addition & 0 deletions Example Assets/com.github.macadmins.Nudge.umad.json
Expand Up @@ -66,6 +66,7 @@
"fallbackLanguage": "en",
"forceFallbackLanguage": false,
"forceScreenShotIcon": false,
"hideDeferralCount": false,
"iconDarkPath": "/somewhere/logoDark.png",
"iconLightPath": "/somewhere/logoLight.png",
"screenShotDarkPath": "/somewhere/screenShotDark.png",
Expand Down
2 changes: 2 additions & 0 deletions Example Assets/com.github.macadmins.Nudge.umad.mobileconfig
Expand Up @@ -131,6 +131,8 @@
<false/>
<key>forceScreenShotIcon</key>
<false/>
<key>hideDeferralCount</key>
<false/>
<key>iconDarkPath</key>
<string>/somewhere/logoDark.png</string>
<key>iconLightPath</key>
Expand Down
4 changes: 3 additions & 1 deletion Nudge/Preferences/PreferencesStructure.swift
Expand Up @@ -365,7 +365,7 @@ extension UserExperience {
// MARK: - UserInterface
struct UserInterface: Codable {
var fallbackLanguage: String?
var forceFallbackLanguage, forceScreenShotIcon: Bool?
var forceFallbackLanguage, forceScreenShotIcon, hideDeferralCount: Bool?
var iconDarkPath, iconLightPath, screenShotDarkPath, screenShotLightPath: String?
var simpleMode, singleQuitButton: Bool?
var umadElements: [UmadElement]?
Expand Down Expand Up @@ -394,6 +394,7 @@ extension UserInterface {
fallbackLanguage: String?? = nil,
forceFallbackLanguage: Bool?? = nil,
forceScreenShotIcon: Bool?? = nil,
hideDeferralCount: Bool?? = nil,
iconDarkPath: String?? = nil,
iconLightPath: String?? = nil,
screenShotDarkPath: String?? = nil,
Expand All @@ -407,6 +408,7 @@ extension UserInterface {
fallbackLanguage: fallbackLanguage ?? self.fallbackLanguage,
forceFallbackLanguage: forceFallbackLanguage ?? self.forceFallbackLanguage,
forceScreenShotIcon: forceScreenShotIcon ?? self.forceScreenShotIcon,
hideDeferralCount: hideDeferralCount ?? self.hideDeferralCount,
iconDarkPath: iconDarkPath ?? self.iconDarkPath,
iconLightPath: iconLightPath ?? self.iconLightPath,
screenShotDarkPath: screenShotDarkPath ?? self.screenShotDarkPath,
Expand Down
16 changes: 9 additions & 7 deletions Nudge/UI/SimpleMode/SimpleMode.swift
Expand Up @@ -91,14 +91,16 @@ struct SimpleMode: View {
}
}

// Maybe make this default to hidden with a pref to enable
// Deferred Count
HStack {
Text("Deferred Count:".localized(desiredLanguage: getDesiredLanguage()))
.font(.title3)
Text(String(self.deferralCountUI))
.font(.title3)
.fontWeight(.bold)
// Show by default, allow to be hidden via preference
if !Utils().hideDeferralCount() {
HStack {
Text("Deferred Count:".localized(desiredLanguage: getDesiredLanguage()))
.font(.title3)
Text(String(self.deferralCountUI))
.font(.title3)
.fontWeight(.bold)
}
}

// actionButton
Expand Down
8 changes: 8 additions & 0 deletions Nudge/Utilities/Preferences.swift
Expand Up @@ -183,6 +183,14 @@ func forceScreenShotIconMode() -> Bool {
}
}

func hideDeferralCount() -> Bool {
if Utils().hideDeferralCount() {
return true
} else {
return userInterfaceProfile?["hideDeferralCount"] as? Bool ?? nudgeJSONPreferences?.userInterface?.hideDeferralCount ?? false
}
}

func simpleMode() -> Bool {
if Utils().simpleModeEnabled() {
return true
Expand Down
9 changes: 9 additions & 0 deletions Nudge/Utilities/Utils.swift
Expand Up @@ -305,6 +305,15 @@ struct Utils {
}
}

func hideDeferralCount() -> Bool {
let hideDeferralCount = CommandLine.arguments.contains("-hide-deferral-count")
if hideDeferralCount {
let msg = "-hide-deferral-count argument passed"
uiLog.debug("\(msg, privacy: .public)")
}
return hideDeferralCount
}

func openMoreInfo() {
guard let url = URL(string: aboutUpdateURL) else {
return
Expand Down

0 comments on commit a2008e6

Please sign in to comment.