-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak Simple mode by adding required and current OS #192
Conversation
Can you switch to the non-debug xcworkspace and take screenshots of just simple mode? My first inclination is to say it's busy, but I think it's because both UIs are rendering in your example. |
I don't use simple mode, so would like anyone who is to chime in on these changes as it does remove UX. |
Nudge/UI/SimpleMode/SimpleMode.swift
Outdated
if !hideDeferralCount() { | ||
HStack { | ||
Text("Deferred Count:".localized(desiredLanguage: getDesiredLanguage())) | ||
.font(.title3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you move to title3? That may be why I dislike the change
also see my comment on standard mode
Nudge/UI/SimpleMode/SimpleMode.swift
Outdated
.font(.title3) | ||
Text(manager.current.description) | ||
.foregroundColor(.secondary) | ||
.font(.title3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO should be title2 to stay consistent with the other textfields. Standard mode keeps the same font weight for all of these UI fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be ready for review again. |
We only use Simple Mode in our environment, and we like the changes Nate is proposing. |
+1 to @macbm's comments This is a good change for our use of simple mode. Presently we overload the "More Info" button to further inform users, but that isn't device-state specific. This strikes a good balance and will probably have a positive impact on user touchpoints. As it is now, we would use this. I have an aesthetic nitpick:
Would perhaps a popover view allow displaying further information in simple mode more elegantly? Perhaps an option for configuring |
We discussed this in Slack a little and for now we are going to try to settle on a standard simple mode UI that has only actionable information for the end user. In this case, its the required version of macOS and how many days they have left to update. The other information is a kind of noise by itself and having all 4 makes Simple mode not so simple. I'm proposing the current diff is the new default and then we can talk about making them a preference or something like that. |
Completely and utterly changed my mind here about showing required OS version. People have no clue what they are on or what is required. Maybe this can be added to the PS: Aligning stuff sucks. The more info button keeps moving 🙄 |
I like this. |
Need review on this. |
25a638e
to
7f6896e
Compare
7f6896e
to
bf18b0d
Compare
@@ -365,7 +365,7 @@ extension UserExperience { | |||
// MARK: - UserInterface | |||
struct UserInterface: Codable { | |||
var fallbackLanguage: String? | |||
var forceFallbackLanguage, forceScreenShotIcon: Bool? | |||
var forceFallbackLanguage, forceScreenShotIcon, showDeferralCount: Bool? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit but all of the keys are alphabetical before this change. Can you move it down to L370?
Alright, by taking the |
This does a few things:
Also I propose making Deferral count hidden by default in Simple mode, but with an option to enable it. The thought process is one can use Simple mode for the first N days of nudging and only switch to full mode if people are ignoring it.
Here is what it looks like with deferralCount:
And without:
It looks a lot cleaner without the deferral count, so the option to disable it would be very good to have (or even disable by default, enable by option, which is my preference).