Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeferView triggers userInitiatedExit() instead of the dismissal sheet #227

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

erikng
Copy link
Member

@erikng erikng commented Aug 23, 2021

Addresses: #226

This code didn't work last week, but it was due to my use of AppKit.NSApp.terminate(nil). When I moved to exit(0), this allowed this code to actually work. I just didn't know about it.

Testing was kind of crappy, but I took the nudge.app debug application and sent it over via SSH to the M1 11.4 machine. Nudge successfully closed. I don't think I'll fully know, until I merge this and create a new release.

This code didn't work last week, but it was due to my use of AppKit.NSApp.terminate(nil). When I moved to exit(0), this allowed this code to actually work. I just didn't know about it.
@erikng erikng added the bug Something isn't working label Aug 23, 2021
@erikng erikng added this to the 1.1 milestone Aug 23, 2021
@erikng erikng added this to In Progress in Nudge v1.1 via automation Aug 23, 2021
@erikng erikng merged commit c6b050b into development Aug 23, 2021
Nudge v1.1 automation moved this from In Progress to Done Aug 23, 2021
@erikng erikng deleted the version-rules-2 branch August 23, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant