Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dynamic hoursRemaining when under a day to cutoff #322

Merged
merged 3 commits into from Feb 22, 2022

Conversation

erikng
Copy link
Member

@erikng erikng commented Feb 22, 2022

addresses: #318

@erikng erikng added the safe to test Allows a PR to be ran with the signing certificates label Feb 22, 2022
@erikng erikng added safe to test Allows a PR to be ran with the signing certificates and removed safe to test Allows a PR to be ran with the signing certificates labels Feb 22, 2022
@erikng
Copy link
Member Author

erikng commented Feb 22, 2022

Screen Shot 2022-02-22 at 10 32 47 AM

@erikng erikng added safe to test Allows a PR to be ran with the signing certificates and removed safe to test Allows a PR to be ran with the signing certificates labels Feb 22, 2022
@erikng
Copy link
Member Author

erikng commented Feb 22, 2022

Screen Shot 2022-02-22 at 10 37 06 AM

@erikng erikng merged commit 4265f80 into development Feb 22, 2022
@erikng erikng deleted the hoursRemaining branch February 22, 2022 16:40
@erikng
Copy link
Member Author

erikng commented Feb 22, 2022

The next version of nudge will go back to days remaining if a negative integer daysRemaining integer is detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Allows a PR to be ran with the signing certificates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants