Resolves issue #38 #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bryanheinz
commented
Sep 28, 2021
bryanheinz
commented
- Updated update_device input to accept both name and device_name input (breaking change)
- data is now updated with the inputs
- Added validation that data has input
- Updated the README with update_device's new inputs
…cing data with params, and adding specific input parameters.
…rom updating the url in _get_data to a local _params variable that is updated with the input params var.
- Updated update_device input to accept both name and device_name input (breaking change) - data is now updated with the inputs - Added validation that data has input - Updated the README with update_device's new inputs
- Return single items without wrapping in list - Fix calls that return a single item. - Resolves issue macadmins#26
|
PR #42 bundled the changes in this PR, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.