Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handling of constant factors when factoring polynomials #39

Closed
DanGrayson opened this issue Jun 1, 2013 · 0 comments
Closed

handling of constant factors when factoring polynomials #39

DanGrayson opened this issue Jun 1, 2013 · 0 comments

Comments

@DanGrayson
Copy link
Member

We should fix it so "factor" does something uniform and predictable when it comes to the constant unit factors it extracts. Ideally each irreducible factor would be monic in the ordering of the ring. Since factor calls Singular-Factory, which uses a different monomial ordering, post-processing to clean up the factorization is required.

Thanks to Paul Zinn-Justin for suggesting it.
pzinn added a commit to pzinn/M2 that referenced this issue Feb 23, 2014
@pzinn
fixes 3 bugs, and implements 1 suggestion:
beecb4b 
- bug Macaulay2#98. factoring Laurent polynomial now works properly.
- related bug. numerator / denominator now work on Laurent polynomials and provide sensible answers.
- isPrime has been rewritten in a clean, factor-order-agnostic way. fixes such bugs as "3*x is not prime in QQ[x]".
- Macaulay2#39. factor now chooses the sign of each factor so that its leading monomial has positive coefficient (if basering is ZZ or QQ; behavior undefined for other baserings)
@pzinn pzinn mentioned this issue Feb 24, 2014
Merged
pzinn added a commit to pzinn/M2 that referenced this issue Feb 24, 2014
@pzinn
fix to implementation of suggestion Macaulay2#39. sign changed only i…
fbd2127 
…f basering of characteristic zero.
pzinn added a commit to pzinn/M2 that referenced this issue Feb 24, 2014
@pzinn
fix to implementation of suggestion Macaulay2#39
15cc75a
@pzinn pzinn mentioned this issue Feb 24, 2014
Merged
@mahrud mahrud closed this as completed Apr 19, 2020
d-torrance pushed a commit to d-torrance/M2 that referenced this issue Dec 24, 2023
@DanGrayson
Merge pull request Macaulay2#39 from d-torrance/jump-to-source-code
96539d5 
Use compilation-shell-minor-mode for jumping to source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DanGrayson @mahrud