Parsing errors are now handled differently - no error is raised in th…

…e code
macbre · Aug 12, 2021 · 6163fd2 · 6163fd2
1 parent 303c2f9
commit 6163fd2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 14 deletions.
diff --git a/lib/css-analyzer.js b/lib/css-analyzer.js
@@ -277,11 +277,7 @@ class CSSAnalyzer {
     this.emit("css", css);
 
     // now go through parsed CSS tree and emit events for rules
-    try {
-      this.run();
-    } catch (ex) {
-      return ex;
-    }
+    this.run();
 
     this.emit("report");
 

diff --git a/rules/specificity.js b/rules/specificity.js
@@ -24,7 +24,7 @@ function rule(analyzer) {
       parts;
 
     /* istanbul ignore if */
-    if (!selectorSpecificity) {
+    if (!selectorSpecificity || !selectorSpecificity[0]) {
       debug("not counted for %s!", selector);
       return;
     }

diff --git a/test/errors.test.js b/test/errors.test.js
@@ -22,13 +22,6 @@ const tests = [
 		check: /css parameter passed is not a string/,
 		code: analyzer.EXIT_CSS_PASSED_IS_NOT_STRING
 	},
-	// issue #98
-	{
-		name: 'Invalid CSS selector',
-		css: 'foo, bar, {color: red}',
-		check: /Unable to parse "" selector. Rule position start @ 1:1, end @ 1:23/,
-		code: analyzer.EXIT_PARSING_FAILED
-	}
 ];
 
 describe('Errors handling', () => {
@@ -37,12 +30,13 @@ describe('Errors handling', () => {
 			it('should raise an error with correct error code', async () => {
 				try {
 					await analyzer(test.css);
-					assert.fail("Expected to fail");
+					assert.fail("analyzer() is expected to fail");
 				}
 				catch(err) {
 					assert.strictEqual(err instanceof Error, true, 'Error should be thrown');
 
 					if (!test.check.test(err.toString())) {
+						console.error('Got instead: ', err);
 						assert.fail(`${test.name} case raised: ${err.message} (expected ${test.check})`);
 					}