Merge 3cbb5cf into 52a5143

lib/index.js

@@ -168,7 +168,7 @@ analyzer.prototype = {
       var rule = require("./../rules/" + name);
       rule(this);
 
-      debug('"%s" loaded: %s', name, rule.description || "-");
+      debug('"%s" loaded: %s', name, rule.description);
     }, this);
   },
 
@@ -209,6 +209,7 @@ analyzer.prototype = {
           this.emit("media", rule.media, rule.rules);
 
           // now run recursively to parse rules within the media query
+          /* istanbul ignore else */
           if (rule.rules) {
             this.parseRules(rule.rules);
           }

lib/preprocessors.js

@@ -21,6 +21,7 @@ preprocessors.prototype = {
     files = glob.sync(__dirname + "/preprocessors/*.js");
     debug("Initializing...");
 
+    /* istanbul ignore next */
     if (Array.isArray(files)) {
       files.forEach(function (file) {
         res.push(require(file));

package.json

@@ -63,12 +63,15 @@
   },
   "jest": {
     "verbose": true,
+    "coveragePathIgnorePatterns": [
+      "test/"
+    ],
     "coverageThreshold": {
       "global": {
-        "statements": 99,
-        "branches": 95,
+        "statements": 100,
+        "branches": 100,
         "functions": 100,
-        "lines": 99
+        "lines": 100
       }
     }
   }

rules/duplicated.js

@@ -39,6 +39,7 @@ function rule(analyzer) {
   analyzer.on("rule", function (rule) {
     var propertiesHash = {};
 
+    /* istanbul ignore else */
     if (rule.declarations) {
       rule.declarations.forEach(function (declaration) {
         var propertyName;

rules/mediaQueries.js

@@ -9,7 +9,7 @@ function rule(analyzer) {
     analyzer.incrMetric("mediaQueries");
     analyzer.addOffender(
       "mediaQueries",
-      format("@media %s (%d rules)", query, (rules && rules.length) || 0)
+      format("@media %s (%d rules)", query, rules.length)
     );
   });
 }

rules/propertyResets.js

@@ -14,7 +14,7 @@ function rule(analyzer) {
   analyzer.setMetric("propertyResets");
 
   analyzer.on("selector", function (rule, selector) {
-    var declarations = rule.declarations || [],
+    var declarations = rule.declarations,
       properties;
 
     // prepare the list of properties used in this selector

rules/specificity.js

@@ -20,6 +20,7 @@ function rule(analyzer) {
     var selectorSpecificity = specificity.calculate(selector),
       parts;
 
+    /* istanbul ignore if */
     if (!selectorSpecificity) {
       debug("not counted for %s!", selector);
       return;

test/sass.test.js

@@ -69,4 +69,18 @@ describe('SASS preprocessor [' + (isSassInstalled ? 'node-sass installed' : 'nod
 			preprocessor: 'sass'
 		}, done);
 	});
+
+	it('should report parsing error when provided an incorrect syntax', done => {
+		try {
+			new analyzer("bar {foo--}", {
+				preprocessor: 'sass'
+			}, done);
+		 }
+		 catch (err) {
+			assert.ok(err instanceof Error);
+			assert.ok(err.message.indexOf("Preprocessing failed:") === 0);
+			done();
+		}
+	});
+
 });