added position dump for unparsed selectors #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -227,7 +227,8 @@ analyzer.prototype = { | |||
| parsedSelector = slickParse(selector)[0]; | |||
|
|
|||
| if (typeof parsedSelector === 'undefined') { | |||
| throw 'Unable to parse "' + selector + '" selector'; | |||
| var positionDump = "Rule position start: " + rule.position.start.line + ',' + rule.position.start.column + "; end: " + rule.position.end.line + ',' + rule.position.end.column; | |||
There was a problem hiding this comment.
Let's be consistent and use the following convention when printing line numbers and columns:
'start @ ' + position.line + ':' + position.column
|
Thanks for the pull request! Please add a test case for handling errors in such case to |
macbre
pushed a commit
that referenced
this pull request
Jun 26, 2015
added position dump for unparsed selectors
macbre
added a commit
that referenced
this pull request
Jun 26, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it is really hard to find empty selectors, like the following (note the last comma):
input.input-text, select, textarea, button, {}