Skip to content

Commit

Permalink
indexdigest/formatters/syslog.py is now fully covered
Browse files Browse the repository at this point in the history
  • Loading branch information
macbre committed Jun 11, 2021
1 parent 033b45f commit d2785aa
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 6 deletions.
4 changes: 2 additions & 2 deletions indexdigest/formatters/syslog.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import indexdigest


def format_report(database, report):
def _format_report(database, report):
"""
:type database indexdigest.database.Database
:type report indexdigest.utils.LinterEntry
Expand Down Expand Up @@ -48,7 +48,7 @@ def format_syslog(database, reports, ident='index-digest'):
syslog.openlog(ident=ident, logoption=syslog.LOG_PID, facility=syslog.LOG_USER)

for report in reports:
syslog.syslog(format_report(database, report))
syslog.syslog(_format_report(database, report))

syslog.closelog()
return ''
16 changes: 12 additions & 4 deletions indexdigest/test/formatters/test_syslog.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from unittest import TestCase
from unittest import TestCase, mock

from indexdigest import VERSION
from indexdigest.formatters.syslog import format_report
from indexdigest.formatters.syslog import _format_report, format_syslog
from . import FormatterTestMixin

from indexdigest.cli.script import get_reports
Expand All @@ -11,7 +11,7 @@ class TestFormatter(TestCase, FormatterTestMixin):

def test_format_report_helper(self):
report = next(self.get_reports_mock())
out = format_report(self.get_database_mock(), report)
out = _format_report(self.get_database_mock(), report)
print(out, report)

self.assertEqual(
Expand All @@ -33,6 +33,14 @@ def test_format_for_real_reports(self):
# pass all reports via syslog formatter
for report in get_reports(database, analyze_data=True):
try:
format_report(database, report)
_format_report(database, report)
except Exception:
self.fail('Failed to format the following report {}'.format(str(report)))

@mock.patch('syslog.syslog')
def test_format_syslog(self, mocked_syslog: mock.MagicMock):
reports = list(self.get_reports_mock())
format_syslog(database=self.get_database_mock(), reports=reports)

assert mocked_syslog.called, 'syslog.syslog has been called'
assert mocked_syslog.call_count == len(reports)

0 comments on commit d2785aa

Please sign in to comment.