Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSRF token should be sent as last parameter in request payload #218

Closed
jwbth opened this issue Aug 18, 2020 · 0 comments · Fixed by #219
Closed

CSRF token should be sent as last parameter in request payload #218

jwbth opened this issue Aug 18, 2020 · 0 comments · Fixed by #219
Labels
Milestone

Comments

@jwbth
Copy link
Contributor

jwbth commented Aug 18, 2020

Currently the order of parameters (specified at https://github.com/macbre/nodemw/blob/devel/lib/bot.js#L494) doesn't comply to the API documentation. It specifies that "The token should always be sent as the last parameter, or at least after the text parameter."

This may result in cropped content if the connection was terminated abruptly, as can be seen in this edit performed by nodemw.

@macbre macbre added the bug label Aug 18, 2020
@macbre macbre added this to the v0.14 milestone Aug 18, 2020
macbre added a commit that referenced this issue Aug 18, 2020
Send CSRF token as last parameter in request payload (#218)
@macbre macbre closed this as completed Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants