Use node-style callbacks throughout

[maxkueng]

Callbacks should be passed an Error as the first argument and data as the second.

Like so:

client.logIn(function (err, data) {
  if (err) { return console.log('login failed', err); }

  console.log('login successful', data);
});

Instead of:

client.logIn(function (data) {
  console.log('maybe login successful', data);
});

[mitar]

+1

[mitar]

So, yes, how does one detect errors at all?

[mitar]

Or, you could expose promises and allow user to hook into success and failure callbacks.

BTW, you also throw exceptions in the code in some callbacks, this is not a good pattern because it can kill the whole server.

[Fannon]

+1

If an error happens, this library does kill my app regularly.

[MattiSG]

+1

Considering using nodemw in production, but this is a dealbreaker. Any timeline? :)

[macbre]

Pull request (#43) issued with proposed fix. I'm also considering removing the support for promises from nodemw.