Add addFlowTopic function to bot class
#120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macbre
requested changes
Dec 18, 2016
| callback(null, data); | ||
| } | ||
| else { | ||
| callback(new Error(`Edit failed: ${err}`)); |
There was a problem hiding this comment.
I'd simply pass err (without creating a new exception object) to the callback to be consistent with the rest of the code.
There was a problem hiding this comment.
Sure, I took example on the doEdit function, this is why it is here. Will fix it asap
There was a problem hiding this comment.
👍
And I'll correct the rest of the cases where err is wrapped within a new exception instance - #121
macbre
approved these changes
Dec 18, 2016
|
Thanks! |
ValentinBrclz
added a commit
to ValentinBrclz/WP-OubliSignature-Bot
that referenced
this pull request
Aug 8, 2017
Using `addFlowTopic()` from macbre/nodemw#120 and version 0.11.0 of the package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
addFlowTopicfunction to bot classFeedback and correction requests are welcome.
This closes #117