allow extra parameters for upload #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no way to send (for example) the `text` parameter in `bot.upload()` or `bot.uploadByUrl()`, so I modified it to allow sending an object in place of summary (comment), which will then be added to the parameters sent with the request.
|
There are probably similar issues elsewhere, but this fixes something I needed, and it preserves backward compatibility. |
ghost
assigned
macbre
added a commit
that referenced
this pull request
Aug 18, 2013
allow extra parameters for upload
|
Thanks! |
|
You probably should tag it 0.3.8. |
|
Tagged and pushed to npm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no way to send (for example) the
textparameter inbot.upload()or
bot.uploadByUrl(), so I modified it to allow sending an object in placeof summary (comment), which will then be added to the parameters sent with
the request.