GetArticleCategories fix #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -378,7 +378,7 @@ module.exports = (function() { | |||
| null, | |||
| (page.categories || []).map(function(cat) { | |||
| // { ns: 14, title: 'Kategoria:XX wiek' } | |||
| return cat.title.split(':')[1]; | |||
| return cat.title.substring(cat.title.indexOf(":")+1); | |||
There was a problem hiding this comment.
Please use tabs instead of spaces.
|
Thanks for the fix. Please address the minor comment above and we're ready to merge. |
|
Sorry for that, should be fine like that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this approach, only the part before the first ":" gets removed.
It was an issue on fr.wiki, since certain categories have several ":"
Catégorie:Wikipédia:Phénix is one of the many examples.