Handle unexisting/deleted pages #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -372,13 +372,16 @@ module.exports = (function() { | |||
| return; | |||
| } | |||
|
|
|||
| if(data === null) | |||
| callback(title+" does not exist", null); | |||
There was a problem hiding this comment.
Please create an instance of Error and then pass it to the callback (nodejs convention).
Fix: missing return statement
|
Here you go. Sorry for that, still learning here =) |
|
No worries :) Thanks for the fix! |
macbre
added a commit
that referenced
this pull request
Nov 15, 2015
Handle unexisting/deleted pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, since "data" is undefined when the requested page is not existing, a type error occurs. This commit just handle the error.