Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parse() method #83

Merged
merged 2 commits into from Nov 20, 2015
Merged

add parse() method #83

merged 2 commits into from Nov 20, 2015

Conversation

g-sun
Copy link
Contributor

@g-sun g-sun commented Nov 17, 2015

contentmodel: 'wikitext',
generatexml: 1
}, function(err, data, next, raw) {
var xml = getFirstItem(raw.parse.text);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will raw.parse.text be always set? Even when err is set?

@macbre
Copy link
Owner

macbre commented Nov 17, 2015

Thanks for the PR. Please update the README.md file with a short description of the introduced function.

Update README.md
@g-sun
Copy link
Contributor Author

g-sun commented Nov 19, 2015

fixed,thanks for reminding

macbre added a commit that referenced this pull request Nov 20, 2015
@macbre macbre merged commit dcfef31 into macbre:master Nov 20, 2015
macbre added a commit that referenced this pull request Nov 20, 2015
@macbre
Copy link
Owner

macbre commented Nov 20, 2015

Backported to the devel branch in fb1a50e

macbre added a commit that referenced this pull request Nov 20, 2015
@macbre macbre modified the milestone: v0.8 Nov 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants