a quick and dirty fix to getToken

[lagleki]

in newer versions of mediawiki action: " 'query', meta: 'tokens' " is required to get the token.

[macbre]

@lagleki, can you be more specific on "newer version of mediawiki"?

nodemw is used for wikis that run MediaWiki 1.19 and the updated URL to get the token simply does not work - e.g. http://www.wikia.com/api.php?action=query&meta=tokens.

[lagleki]

=1.24 as the official docs say.
https://www.mediawiki.org/wiki/API:Tokens

Looks like they implemented that in somewhere in August 2014:
https://www.mail-archive.com/mediawiki-api@lists.wikimedia.org/msg03286.html

But I agree that this fix makes older wikis not work so maybe a new flag in
options might be necessary. It would switch the behavior.

2016-01-14 20:11 GMT+03:00 Maciej Brencz notifications@github.com:

@lagleki https://github.com/lagleki, can you be more specific on "newer
version of mediawiki"?

nodemw is used for wikis that run MediaWiki 1.19 at the updated list of
URL parameters do not work - e.g.
http://www.wikia.com/api.php?action=query&meta=tokens.

—
Reply to this email directly or view it on GitHub
#91 (comment).

[smiley]

If this is a breaking change, why not fetch the wiki's version on initial load via "query", meta: "siteinfo", siprop: "general"? That returns:

{
    "batchcomplete": "",
    "query": {
        "general": {
            "mainpage": "Main Page",
            "base": "https://en.wikipedia.org/wiki/Main_Page",
            "sitename": "Wikipedia",
            "logo": "//en.wikipedia.org/static/images/project-logos/enwiki.png",
            "generator": "MediaWiki 1.27.0-wmf.18", /* This corresponds to the version in "Special:Version" */
/* ... */

That way, nodemw could pick the correct behaviour per wiki. (It could even be done asynchronously and only delay token-requiring actions, so read-only actions would be unaffected)

[lagleki]

Or even simpler. Fallback to the new behavior if the old one returns an
error

Em sábado, 26 de março de 2016, Smiley Barry notifications@github.com
escreveu:

If this is a breaking change, why not fetch the wiki's version on initial
load via "query", meta: "siteinfo", siprop: "general"? That returns:

{
"batchcomplete": "",
"query": {
"general": {
"mainpage": "Main Page",
"base": "https://en.wikipedia.org/wiki/Main_Page",
"sitename": "Wikipedia",
"logo": "//en.wikipedia.org/static/images/project-logos/enwiki.png",
"generator": "MediaWiki 1.27.0-wmf.18", /* This corresponds to the version in "Special:Version" // ... */

That way, nodemw could pick the correct behaviour per wiki. (It could
even be done asynchronously and only delay token-requiring actions, so
read-only actions would be unaffected)

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#91 (comment)

[macbre]

@smiley good idea. Let's detect the MW version (lazy fetch it once for each nodem instance) and act accordingly.

[lagleki]

Has this already been implemented?

[macbre]

Not yet, let's first implement the MW version detection (which I'm working on right now).

[macbre]

@lagleki: done. Thanks for suggesting the change :)