Bump eslint to 9.x (#1371)

* Install eslint 9.3.0

npm i --save-dev eslint@latest eslint-config-prettier@latest

* npm remove eslint-plugin-node

* npm i --save-dev globals @eslint/js

* Initial version of eslint.config.js (migrated away from the legacy YAML file)

* Fix / ignore browser globals being redeclared

* examples/screenshot.js: use process.exit()

* Ignore no-empty for try / catch blocks

* requestsMonitor: fix "Unexpected constant truthiness on the left-hand side"

* bin/phantomas.js: use process.exit()

* Prettify the code

bin/phantomas.js

@@ -22,8 +22,7 @@ let options = parseArgv(process.argv);
 if (typeof options.url !== "string" && typeof options.config === "undefined") {
   debug("URL not provided - show help and leave");
   getProgram().outputHelp();
-  process.exitCode = 1;
-  return;
+  process.exit(1);
 }
 
 url = options.url;

core/modules/requestsMonitor/requestsMonitor.js

@@ -40,7 +40,7 @@ function parseEntryUrl(entry) {
     entry.protocol = false;
     entry.isBlob = true;
   } else {
-    parsed = new URL(entry.url) || {};
+    parsed = new URL(entry.url);
 
     entry.protocol = parsed.protocol.replace(":", ""); // e.g. "http:"
     entry.domain = parsed.hostname;

core/scope.js

@@ -114,6 +114,7 @@
           console,
           "log:" + stringify(Array.prototype.slice.call(arguments))
         );
+        // eslint-disable-next-line no-empty
       } catch (e) {}
     };
 

eslint.config.js

@@ -0,0 +1,39 @@
+const globals = require("globals");
+const js = require("@eslint/js");
+
+const eslintConfigPrettier = require("eslint-config-prettier");
+
+module.exports = [
+  js.configs.recommended,
+  eslintConfigPrettier,
+  {
+    languageOptions: {
+      ecmaVersion: 2022,
+      sourceType: "script",
+      globals: {
+        // https://eslint.org/docs/latest/use/configure/language-options#predefined-global-variables
+        ...globals.node,
+        ...globals.browser,
+      },
+    },
+    rules: {
+      "prefer-const": "off",
+      "no-console": "off",
+      "no-async-promise-executor": "off",
+      // https://eslint.org/docs/latest/rules/no-unused-vars
+      "no-unused-vars": [
+        "error",
+        {
+          vars: "all",
+          args: "after-used",
+          caughtErrors: "none", // ignore catch block variables
+          ignoreRestSiblings: false,
+          reportUsedIgnorePattern: false,
+        },
+      ],
+    },
+  },
+  {
+    ignores: ["coverage/**", "test/webroot/**"],
+  },
+];

examples/screenshot.js

@@ -12,8 +12,7 @@ var phantomas = require(".."),
 
 if (typeof url !== "string") {
   console.log("Usage:\n\t./screenshot.js <URL>");
-  process.exitCode = 1;
-  return;
+  process.exit(1);
 }
 
 run = phantomas(url, {

extensions/postLoadDelay/postLoadDelay.js

@@ -3,7 +3,7 @@
  */
 "use strict";
 
-const { setTimeout } = require("timers/promises");
+const { setTimeout: setTimeoutAsync } = require("timers/promises");
 
 module.exports = function (phantomas) {
   // e.g. --post-load-delay 5
@@ -19,6 +19,6 @@ module.exports = function (phantomas) {
   phantomas.on("beforeClose", async () => {
     phantomas.log("Sleeping for %d seconds", delay);
 
-    return setTimeout(delay * 1000);
+    return setTimeoutAsync(delay * 1000);
   });
 };