analyze-css process not finishing

[gmetais]

Sometimes, when running phantomas with --analyze-css, the page gets fully loaded before all the analyze-css sub-processes have finished.

It happens sometimes for me on this url: http://www.priceminister.com
When running in --verbose mode, i can see for example 7 sub-processes starting and only 5 of them ending.

Also, i'm testing the devel version of analyze-css. And i did not notice the problem before. So maybe one of the recently added analyze-css metrics makes the tests last longer?

15:26:11.159 runScript: pid #3571 done (took 774 ms)
15:26:11.164 runScript: pid #3567 done (took 964 ms)
15:26:11.171 runScript: pid #3569 done (took 843 ms)
15:26:11.187 runScript: pid #3565 done (took 1046 ms)

Gaël

[gmetais]

This page is a good test case:
http://stevesouders.com/cuzillion/?c0=hc1hfff2_0_f&c1=hc1hfff2_0_f&c2=hc1hfff2_0_f&c3=hc1hfff2_0_f&c4=hc1hfff2_0_f&c5=hc1hfff2_0_f&c6=hc1hfff2_0_f&t=1416488099110

[gmetais]

Here is a fix proposition:
https://github.com/gmetais/YellowLabTools/blob/wait4css/phantomas_custom/modules/analyzeStyleYLT/analyzeStyleYLT.js#L118

Hope i'm doing it right.

[macbre]

@gmetais, thanks for the fix proposal. I think I'll fix it in phantomas.runScript function to not repeat the same fix in the future uses of this function.

[gmetais]

You're right, that's a better idea!

[macbre]

19:58:49.529 runScript: /home/macbre/github/phantomas/node_modules/.bin/analyze-css --url http://1.cuzillion.com/bin/resource.cgi?type=css&sleep=2&n=7&t=1417204724 --json (pid #7840)
19:58:49.555 Page loading finished ("success")
19:58:49.555 Event loadFinished emitted
19:58:49.559 Loading progress: 100%
19:58:49.560 Event progress emitted
19:58:50.436 runScript: pid #7803 done (took 3155 ms)
19:58:50.437 analyzeCss: using analyze-css v0.7.0
19:58:50.438 runScript: pid #7804 done (took 3151 ms)
19:58:50.438 analyzeCss: using analyze-css v0.7.0
19:58:50.468 runScript: pid #7805 done (took 3172 ms)
19:58:50.468 analyzeCss: using analyze-css v0.7.0
19:58:50.841 runScript: pid #7810 done (took 3512 ms)
19:58:50.841 analyzeCss: using analyze-css v0.7.0
19:58:51.576 runScript: pid #7812 done (took 4233 ms)
19:58:51.576 analyzeCss: using analyze-css v0.7.0
19:58:51.579 runScript: pid #7808 done (took 4268 ms)
19:58:51.579 analyzeCss: using analyze-css v0.7.0
19:58:52.230 runScript: pid #7840 done (took 2704 ms)
19:58:52.230 analyzeCss: using analyze-css v0.7.0
19:58:52.231 Event report emitted
19:58:52.231 phantomas run for <http://stevesouders.com/cuzillion/?c0=hc1hfff2_0_f&c1=hc1hfff2_0_f&c2=hc1hfff2_0_f&c3=hc1hfff2_0_f&c4=hc1hfff2_0_f&c5=hc1hfff2_0_f&c6=hc1hfff2_0_f&t=1416488099110> completed in 8505 ms