-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added browser storage handling as seperate extension #1025
Conversation
…rage of Browser object
Thanks for your PR, @kevinkammleiter ! A few small things to clean up before this can be merged:
Thanks once again! |
Thanks for the suggested improvements. 👍 I will start soon with implementing the changes and update the pull request. |
Hi @macbre! I added the changes you suggested. Thanks again for the hints! 👍 |
"session-storage": "bar=foo" | ||
metrics: | ||
session-storage: '{"bar":"foo"}' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@kevinkammleiter - thanks for contributing, merging! |
Actually, @kevinkammleiter - can you apply my above suggestion (regarding wording in |
Hello guys,☺️
we have a little contribution for you and it would be great, if you could review the changes and hopefully bringing this in a future release
For authentication purposes it could be useful, to have the ability to inject several session-/localStorage values into the page handled by puppeteer.
This extension will use the phantomas parameter sessionStorage and localStorage and inject them into the page storage respectively.