Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests - use nginx-http3:1.21.6 container #1052

Merged
merged 10 commits into from
Apr 26, 2022
Merged

Tests - use nginx-http3:1.21.6 container #1052

merged 10 commits into from
Apr 26, 2022

Conversation

macbre
Copy link
Owner

@macbre macbre commented Dec 16, 2021

No description provided.

@macbre macbre enabled auto-merge (squash) December 16, 2021 20:04
@macbre macbre changed the title Tests - nginx-http3:1.21.4 Tests - use nginx-http3:1.21.4 container Dec 16, 2021
@macbre
Copy link
Owner Author

macbre commented Dec 16, 2021

Failing tests caused by new set of response headers added after macbre/docker-nginx-http3#65

@macbre macbre changed the title Tests - use nginx-http3:1.21.4 container Tests - use nginx-http3:1.21.6 container Feb 2, 2022
@macbre
Copy link
Owner Author

macbre commented Apr 25, 2022

Expected value to deeply and strictly equal to:
      [{"size": 342, "url": "http://127.0.0.1:8888/static/blank.gif"}]
    Received:
      [{"size": 327, "url": "http://127.0.0.1:8888/static/blank.gif"}]

There's a difference of 15 bytes.

@macbre

This comment was marked as outdated.

macbre added a commit that referenced this pull request Apr 26, 2022
Debug headers difference as found in #1052
macbre added a commit that referenced this pull request Apr 26, 2022
Debug headers difference as found in #1052
@macbre
Copy link
Owner Author

macbre commented Apr 26, 2022

++ curl -svo /dev/null --compressed 0.0.0.0:8888/static/style.css
*   Trying 0.0.0.0:8888...
* TCP_NODELAY set
* Connected to 0.0.0.0 (127.0.0.1) port 8888 (#0)
> GET /static/style.css HTTP/1.1
> Host: 0.0.0.0:8888
> User-Agent: curl/7.68.0
> Accept: */*
> Accept-Encoding: deflate, gzip, br
> 
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Date: Tue, 26 Apr 2022 08:56:20 GMT
< Content-Type: text/css
< Content-Length: 22
< Last-Modified: Tue, 26 Apr 2022 08:[55](https://github.com/macbre/phantomas/runs/6172507199?check_suite_focus=true#step:6:55):[56](https://github.com/macbre/phantomas/runs/6172507199?check_suite_focus=true#step:6:56) GMT
< Connection: keep-alive
< ETag: "6267b39c-16"
< Expires: Wed, 27 Apr 2022 08:56:20 GMT
< Cache-Control: max-age=86400
< Accept-Ranges: bytes
< 
{ [22 bytes data]
* Connection #0 to host 0.0.0.0 left intact
* ```

@macbre
Copy link
Owner Author

macbre commented Apr 26, 2022

< Server: nginx

is missing due to https://github.com/macbre/docker-nginx-http3/blob/master/nginx.conf#L36-L37

Exactly the missing 15 bytes!

@macbre macbre merged commit 70b4c98 into devel Apr 26, 2022
@macbre macbre deleted the tests/nginx-1.21.4 branch April 26, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant