Add support for viewport option #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macbre
added
Chrome-headless
macbre
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @macbre,
I'm adding in this pull request a viewport extension, that allows one to specify any window dimension:
Example: 1100x700
It also supports setting pixel density ratio, using the following syntax:
1100x700x2
I hope this code is conform to how you were seeing things.
Just a note on integration tests. Tests were failing when using window.outerWidth and window.outerHeight as in devices.html. I had to use inner dimensions for the tests to pass (window.innerWidth and window.innerHeight) in a new viewport.html file.