Adjustments to lazyloadable images #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macbre
reviewed
Oct 5, 2020
| @@ -246,6 +246,11 @@ Browser.prototype.visit = (url, waitUntil, timeout) => { | |||
|
|
|||
| // we're done | |||
| Browser.prototype.close = async () => { | |||
| // Allow the beforeunload event to be executed | |||
| // https://github.com/puppeteer/puppeteer/blob/v1.11.0/docs/api.md#pagecloseoptions | |||
| if (this.page) await this.page.close({runBeforeUnload: true}); | |||
macbre
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a couple of fixes for some cases where the lazyloadableImages module was not accurate.
Part 1:
The new engine now interprets
<picture>tags. I've changed the way we read URLs in the lazyloadableImages module, so that it can pick the<source>URL that is actually loaded by the browser. Same for<img>tags with a srcset attribute, this pull request picks the URL that is actually loaded.Part 2:
On some websites, images are loaded very lately, for example in a slider or a carousel. I can see they are loaded in the requests list (when using the --wait-for-network-idle option), but they don't appear in the "lazyloadable" list. I've changed when images are analyzed, switching from window.onLoad to window.onBeforeUnload.
See you!