Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore cache busting hash in URL #7

Closed
riklewis opened this issue Jul 6, 2017 · 3 comments
Closed

Ignore cache busting hash in URL #7

riklewis opened this issue Jul 6, 2017 · 3 comments

Comments

@riklewis
Copy link

riklewis commented Jul 6, 2017

At the moment, if I have a process which adds a cache busting hash at the end of the URL, this plugin no longer works and I get an error such as...

Error: ENOENT: no such file or directory, open 'C:\Users\projectpath\build\css\style.css?cbh=5da92178ce374635e14b17a2e0038469'

I've had to move my "gulp-hash-src" task to after this one, which is fine, but it would be better if it worked either way.

In short, perhaps when loading .js and .css files locally, you could ignore the query string ("?" onwards).

Cheers, Rik

@macedigital
Copy link
Owner

Hi Rik, thanks for your report.

With the latest commit, querystrings are now ignored when resolving file paths. That should fix the issue.

I'll make a new release tomorrow.

@riklewis
Copy link
Author

riklewis commented Jul 7, 2017

Great, thanks!

@macedigital
Copy link
Owner

@riklewis v1.4.0 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants