Feat: Strip querystring-like trailers from local paths (#7)

When discovering that a normalized file path contains a '?' character, everything (including the '?' character itself) will be stripped from it. Fixes #7.
macedigital · Jul 6, 2017 · 04ff6e9 · 04ff6e9
1 parent 25af3d8
commit 04ff6e9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -38,6 +38,11 @@ function normalizePath(node, config) {
     src = path.sep + src;
   }
 
+  // remove query-string from path
+  if (src.indexOf('?') !== -1) {
+    return src.substr(0, src.indexOf('?'));
+  }
+
   return src;
 }
 

diff --git a/test/fixtures/flat/transform.html b/test/fixtures/flat/transform.html
@@ -3,7 +3,7 @@
 <head>
   <meta charset="UTF-8">
   <title>Title</title>
-  <link rel="stylesheet" href="css/styles.css">
+  <link rel="stylesheet" href="css/styles.css?v=123">
   <link rel="stylesheet" href="css/styles.css" media="screen">
   <link rel="stylesheet alternate" href="http://insecure.com/style.css?version=1">
   <link rel="stylesheet" href="https://secure.com/css/styles.css">

diff --git a/test/fixtures/nested/folder/html/index.html b/test/fixtures/nested/folder/html/index.html
@@ -7,6 +7,6 @@
 </head>
 <body>
   <h1>Title</h1>
-  <script src="../scripts/script.js" data-sri-hash="1"></script>
+  <script src="../scripts/script.js?v=123" data-sri-hash="1"></script>
 </body>
 </html>