Add before-script and after-script hooks

[kelunik]

Would be nice if it could run git describe --tags optionally and define a version constant like PHAR_BUILDER_GIT_VERSION. It would remove the need to always change a file before tagging a new release.

Might as well be done by using a script to release new versions.

[MacFJA]

I'm not sure to understand what you try to do 😕

[kelunik]

I want to provide a command line command like acme-client version that shows the current version. In case it's a nightly build (not one from a tag), version with git describe --tags would be something like v0.2.4-3-ga05a4f8. Since the packaged version doesn't have any .git info available, I need to package it somehow.

I could use a script that gets that information and builds the phar afterwards, but it would be nice if there was support directly in here, which would avoid the need for an extra script.

[kelunik]

My current proposal would be something like

"before-script": [
    "git describe --tags > build/version.txt"
],
"after-script": [
    "rm build/version.txt",
    "chmod +x build/acme-client.phar"
]

in the "extra" section in the composer.json.

[MacFJA]

Something similar to Composer event script, why not.

Another idea is to create a new constant in the phar stub (bootstrap) code.
something like:

$this->phar->setStub(
    '#!/usr/bin/env php' . PHP_EOL .
    '<?php Phar::mapPhar(); ' . 
    (null === $constant?'':'define(\'PHAR_VERSION\', \''.addslashes($constant).'\');') . 
    'include "phar://' . $this->alias . '/' . $this->stubFile .
    '"; __HALT_COMPILER(); ?>'
);

And in the console call:

$ phar-builder package --version=`git describe --tags`

But your proposal allow to have event based addition action/control which can be lot more flexible

[MacFJA]

@kelunik, I made a first version of the hooks/event implementation (see e6ebea5).

I have to finish the documentation about it.

[kelunik]

PHP Fatal error: Uncaught Error: Class 'League\Event\Emitter' not found in /home/kelunik/GitHub/kelunik/acme-client/vendor/macfja/phar-builder/app/Application.php:68

Somehow, league/event doesn't get installed even if it's in the composer.json.

[kelunik]

And it doesn't respect the output-dir configuration option anymore.

[kelunik]

Also PHP Warning: Declaration of MacFJA\PharBuilder\Event\ComposerAwareEvent::named($name, $composer) should be compatible with League\Event\Event::named($name) in /home/kelunik/GitHub/kelunik/acme-client/vendor/macfja/phar-builder/app/Event/ComposerAwareEvent.php on line 15

[MacFJA]

Also PHP Warning: Declaration of MacFJA\PharBuilder\Event\ComposerAwareEvent::named($name, $composer) should be compatible with League\Event\Event::named($name) in /home/kelunik/GitHub/kelunik/acme-client/vendor/macfja/phar-builder/app/Event/ComposerAwareEvent.php on line 15

It's the second times! I really need to found a way to detect this! (Correct in 97bfa5f by the way)

[kelunik]

I think the warning is only printed in PHP 7?

[MacFJA]

Nope, it's my PHP(s) configuration: the E_STRICT flag is missing in error_reporting of my php.ini

[kelunik]

Did you have a look at the output dir?

[MacFJA]

Yep, normally it's corrected with the commit e5bb1ec

[kelunik]

"league/event": "^2.1" is missing as requirement.

[kelunik]

And another thing afterwards:

Uncaught Error: Class 'Neutron\SignalHandler\SignalHandler' not found
in /acme-client/vendor/macfja/phar-builder/app/Event/EventManager.php:76

https://packagist.org/packages/neutron/signal-handler

[kelunik]

After that, it fails with

Warning: require(phar:///acme-client/build/acme-client.phar/vendor/composer/../symfony/polyfill-mbstring/bootstrap.php): failed to open stream: phar error: "vendor/symfony/polyfill-mbstring/bootstrap.php" is not a file in phar "/acme-client/build/acme-client.phar" in phar:///acme-client/build/acme-client.phar/vendor/composer/autoload_real.php on line 65

[MacFJA]

Are you sure to use the right branch for your test?

Those two dependencies are declared in the branch events+issue-17 but not on the master

[kelunik]

That might be the case because I used dev-master#hash before, because the branch didn't work. I opened an issue: composer/composer#5397. I guess it's related to the + in the branch name.

[kelunik]

Bug in Composer is gone now. Issue with polyfill-mbstring persists. It's required, because it's listed in autoload.files. I think we had that issue before? Do we need stubs for that?

[kelunik]

#21 fixes this.