Add a test for the doc-generator #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machadovilaca
requested changes
Apr 11, 2024
avlitman
force-pushed
the
add-test-for-doc
branch
from
feaa413
to
8494136
Compare
|
@machadovilaca Fixed your comment, WDYT? |
avlitman
force-pushed
the
add-test-for-doc
branch
from
8494136
to
4c9693a
Compare
Signed-off-by: avlitman <alitman@redhat.com>
avlitman
force-pushed
the
add-test-for-doc
branch
from
4c9693a
to
5cdeaf3
Compare
Comment on lines
+87
to
+97
| It("Checks that the metrics doc is sorted by metrics and recording rules name", func() { | ||
| templateDocMetrics := BuildMetricsDocsWithCustomTemplate(metrics, recordingRules, tpl) | ||
| indexOfA := strings.Index(templateDocMetrics, "AExampleRecordingRule") | ||
| indexOfB := strings.Index(templateDocMetrics, "BExampleGauge") | ||
| indexOfC := strings.Index(templateDocMetrics, "CExampleRecordingRule") | ||
| indexOfD := strings.Index(templateDocMetrics, "DExampleCounterVec") | ||
|
|
||
| Expect(indexOfA).To(BeNumerically("<", indexOfB)) | ||
| Expect(indexOfB).To(BeNumerically("<", indexOfC)) | ||
| Expect(indexOfC).To(BeNumerically("<", indexOfD)) | ||
| }) |
machadovilaca
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test to verify the doc generator adding metrics and recording rules.