Ensure order of recording rule registration in PrometheusRule

[fossedihelm]

It could happen that there are several
prometheus rules with the same name but different
expression.
Since the range in a for loop does not provide
always the same order, it could happen the
resulting prometheus rule list to be different.

[machadovilaca]

thank you for the PR @fossedihelm
can you improve the unit test -

operator-observability/pkg/operatorrules/prometheusrules_test.go

Line 97 in 432fa4d

It("should sort the recording rules of alerts by name ('Record')", func() {

to have 2 recording rules with the same name, and make sure they are sorted by the expression?

[machadovilaca]

I think we should also change the PR title to reflect the changes
wdyt about "Ensure order of recording rule registration in PrometheusRule"?

[machadovilaca]

This unit test definitely needs to be refactored
I need to take a look at it later

Thank you for the fix 🙌

[fossedihelm]

This unit test definitely needs to be refactored I need to take a look at it later

Thank you for the fix 🙌

Agree! Honestly, I didn't dwell much on refactoring it, due to the hotfix :)
Thank you for your fast interaction