New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional alerts validations #4
Add optional alerts validations #4
Conversation
@assafad please update the PR description and add the link to Jira in a separate line. |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a unit test for this verification
also, do you think this should be a mandatory rule for every operator that uses this library, or it should be optional?
I think we should make it optional. |
d8f32a3
to
b8f254c
Compare
b8f254c
to
bd1b19d
Compare
30c3831
to
100a2c7
Compare
100a2c7
to
8336ef3
Compare
Signed-off-by: assafad <aadmi@redhat.com>
8336ef3
to
63585cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the PR and for the fixes in the previous code
good work
After #4, this commit mentions in AlertsAndRecordingRulesValidation.md the availability of the new custom alert validation rules created
Add the following custom alert validations:
runbook_url
annotation.operator_health_impact
,kubernetes_operator_part_of
andkubernetes_operator_component
labels.Fixes https://issues.redhat.com/browse/CNV-31132.