Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE file? #6

Closed
ahwillia opened this issue Sep 21, 2016 · 5 comments
Closed

LICENSE file? #6

ahwillia opened this issue Sep 21, 2016 · 5 comments

Comments

@ahwillia
Copy link
Contributor

I am potentially interested in trying to extend this code for research purposes. This might involve porting some of this code to Julia, since I have been using that for some of my other projects. I also may play around with the MATLAB code a bit (specifically, I'd like to modify the dpca_marginalize function).

Can I recommend that you add a permissive license (e.g. MIT) to this repo so that others can repurpose your code (under the condition that they give proper attribution/recognition to your work)?

@wielandbrendel
Copy link
Collaborator

Thanks for the note - you are right, we should put a license file. I am definitely in favour of a permissive license like MIT, though I can also see a certain appeal for a copy-left license (like GNU GPLv3).

@dkobak : What do you think?

@wielandbrendel
Copy link
Collaborator

@ahwillia : I noticed that your fork of dPCA adds a couple of improvements (setup.py & documentation). Would you be willing to open a pull request to push these changes to our repository? Also, should you implement dPCA in Julia, we could add a new subfolder for this language.

@ahwillia
Copy link
Contributor Author

Thanks! I'm travelling for the next few days but I can organize a PR in the
next week or so if you want.

On Sep 22, 2016 12:16 AM, "Wieland Brendel" notifications@github.com
wrote:

@ahwillia https://github.com/ahwillia : I noticed that your fork of
dPCA adds a couple of improvements (setup.py & documentation). Would you be
willing to open a pull request to push these changes to our repository?
Also, should you implement dPCA in Julia, we could add a new subfolder for
this language.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#6 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAm20XK2v3lYOfSxM_kFHYYJAZMBDhG2ks5qsitdgaJpZM4KDS7g
.

@wielandbrendel
Copy link
Collaborator

Yes, that would be awesome! Looking forward.

@wielandbrendel
Copy link
Collaborator

Added MIT license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants