Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check binary owner on PreCreateCheck() #75

Merged
merged 2 commits into from
Jan 21, 2016
Merged

Add check binary owner on PreCreateCheck() #75

merged 2 commits into from
Jan 21, 2016

Conversation

zchee
Copy link
Member

@zchee zchee commented Jan 20, 2016

See also #75

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
- #75

Signed-off-by: Koichi Shiraishi <k@zchee.io>
@johanneswuerbach
Copy link
Contributor

This won't support sudo docker-machine create -d xhyve right? I would like if both cases are handled and the driver checks before every command stop, restart touching xhyve whether the permissions are correct. WDYT?

@zchee
Copy link
Member Author

zchee commented Jan 20, 2016

@johanneswuerbach That's correct.
PreCreateCheck() is only called when creating command.
I think need check owner before all commands such as PreCommandCheck()(or PreOwnerCheck?).
I will more fix when merged this PR.

but, Do we require corrective action of sudo?
Currently, there are users who would put the sudo before docker-machine command, but docker-machine other drivers are not instructed put the sudo.
So, I think solve if I write a more detail usage.
When install by Homebrew, users do not know how to use and flags, they will see this repository.

Check of the owner is required.
and, If does not exists $HOME/.docker directory, boot2docker.iso file and $HOME/.docker/machine/cache directory will be create by root owner.

This problem is also required improve.

WDYT?

Sorry, I am sleepy, English is rough... 🙀

@zchee
Copy link
Member Author

zchee commented Jan 20, 2016

@johanneswuerbach But put as insurance might be good!

@zchee
Copy link
Member Author

zchee commented Jan 21, 2016

@johanneswuerbach I created other issue.
It will tentatively merge this PR.

zchee added a commit that referenced this pull request Jan 21, 2016
Add check binary owner on PreCreateCheck()
@zchee zchee merged commit 525477c into master Jan 21, 2016
@zchee zchee removed the in progress label Jan 21, 2016
@zchee zchee deleted the homebrew branch January 21, 2016 10:52
@johanneswuerbach
Copy link
Contributor

Thanks, 🙇

@zchee
Copy link
Member Author

zchee commented Jan 21, 2016

@johanneswuerbach Create pull-request!
#78

Handling own binary owner, and sudo before docker-machine command.
It's probably working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants